He joined the 13^th Edinburgh Company, Corstorphine, as a Life Boy in 1944.  After completing his National Service, he took command of the 13^th Life Boys in 1959, and continued in charge of the re-named Junior Section until 1977. At the same time he was a serving Company Section officer, and is well-remembered as a drill officer in the boom years of Company membership in the Sixties and Seventies.  David retained an active connection with the Old Parish Company until his death.

Immaculately turned out in dark navy suit and officer’s glengarry, sharp and strict with his commands, "DC", as he was affectionately known, seemed an embodiment of William Smith’s founding principles of "drill, discipline and self-respect". But, at the side of the hall, and on company camps, he was kind and approachable.

In church on the Sunday before he died David gave the readings. He was particular pleased as the appointed reading ended with the words from St Luke 2:52…"And Jesus grew in wisdom, and in stature, and in favour with God and man". These were the foundations of the Junior Section Achievements David taught to the Boys and were also the building blocks of all that David hoped to achieve in his work with the Boys and in the Battalion.

His service to the Boys’ Brigade in Edinburgh was recognised in 1978 when he was made Battalion Secretary.  As well as serving on numerous committees he held the posts of Christian Faith Convenor and Training Convenor, before becoming Battalion Vice-President, and on the formation of the larger Edinburgh, Leith & District Battalion became Secretary until his retirement from this post in September 2003. Meanwhile accumulating over 40 years uninterrupted membership on the Battalion Executive. He represented the Battalion on many occasions, including royal visits and international camps.

An only child, whose parents had moved to the fringes of Corstorphine for his father’s office job on the railways, he was in the habit of walking with his father to school every morning. One day, when he was 13, his lessons were interrupted with the news that his father was dead David had left him only an hour before.

David remained with his mother in the family home until her death. He followed his father into employment with the railways before moving on to lifelong employment with the civil service.

He wore his Boys’ Brigade Gold Long Service badge with pride, he honoured the past of his own name through his time as secretary to the Clan Association of the Macnabs. He became president during 1977, the year of the International Gathering of the Clans, and oversaw the most successful ever bringing together of the Macnab clan.